Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styling): Fix annotation layer styling #703

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

karelee7
Copy link
Contributor

@karelee7 karelee7 commented Aug 2, 2023

Moving annotation layer related stylings to this repository for better organization. These styling changes resolve issues found in the new PDFjs upgrade related to a change that they made to the z-index for the textLayer.

@karelee7 karelee7 requested a review from a team as a code owner August 2, 2023 17:07
@karelee7 karelee7 force-pushed the fix-annotation-layer-styling branch from d31bc73 to 646324b Compare August 2, 2023 18:04
Copy link
Contributor

@JChan106 JChan106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, looks good

src/image/ImageAnnotator.scss Show resolved Hide resolved
JChan106
JChan106 previously approved these changes Aug 2, 2023
@karelee7 karelee7 force-pushed the fix-annotation-layer-styling branch from bd74e3e to 6819331 Compare August 2, 2023 21:04
Copy link
Contributor

@bfoxx1906 bfoxx1906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karelee7 karelee7 merged commit 20dce4a into box:master Aug 2, 2023
@karelee7 karelee7 deleted the fix-annotation-layer-styling branch August 2, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants