refactor(feature): remove discoverability feature check #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweeii
changed the title
cweeii
force-pushed
the
remove-discoverability-feature-check
branch
from
78e5e3a to
c5a6106
Compare
jstoffan
previously approved these changes
Mar 15, 2021
test/index.html
Outdated
|
|
||
| /* global Box */ | ||
| var preview = new Box.Preview(); | ||
|
|
||
| preview.show(fileid, token, { | ||
| container: '.preview-container', | ||
| boxAnnotations: annotations, | ||
| enableAnnotationsDiscoverability: true, | ||
| enableAnnotationsImageDiscoverability: true, |
There was a problem hiding this comment.
Should we remove the image discoverability feature, as well?
There was a problem hiding this comment.
I spoke with @ConradJChan , seems like a good idea, will update!
test/index.html
Outdated
| @@ -56,15 +56,14 @@ | |||
| } | |||
|
|
|||
| /* global BoxAnnotations */ | |||
| var annotations = new BoxAnnotations(null, { features: { discoverability: true, drawing: true } }); | |||
| var annotations = new BoxAnnotations(null, { features: {} }); | |||
There was a problem hiding this comment.
It looks like we can remove the features object now.
|
I figure the cleanup of the feature checks was pretty small, so I didn't split them into separate prs. If you see something that I missed please let me know! I'm all for splitting them up if it makes the change more organized. |
ConradJChan
previously approved these changes
Mar 16, 2021
cweeii
changed the title
jstoffan
previously approved these changes
Mar 16, 2021
jstoffan
reviewed
Mar 16, 2021
src/document/DocumentAnnotator.ts
Outdated
| @@ -95,8 +95,7 @@ export default class DocumentAnnotator extends BaseAnnotator { | |||
| managers.add(new RegionManager({ location: pageNumber, referenceEl: pageReferenceEl, resinTags })); | |||
|
|
|||
| const canvasLayerEl = pageEl.querySelector<HTMLElement>('.canvasWrapper'); | |||
| const referenceEl = | |||
| this.isFeatureEnabled('discoverability') && canvasLayerEl ? canvasLayerEl : pageReferenceEl; | |||
| const referenceEl = canvasLayerEl || pageReferenceEl; | |||
There was a problem hiding this comment.
We could probably inline this in the object literal below, if desired.
cweeii
changed the title
jstoffan
approved these changes
Mar 16, 2021
ConradJChan
pushed a commit
that referenced
this pull request
Mar 17, 2021
This reverts commit 0160d0a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.