feat(drawing): Add PopupDrawingToolbar #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
reviewed
Dec 8, 2020
| @@ -13,6 +14,8 @@ export default createReducer<DrawingState>(initialState, builder => | |||
| .addCase(addDrawingPathGroupAction, (state, { payload }) => { | |||
| state.drawnPathGroups.push(payload); | |||
| }) | |||
| .addCase(resetCreatorAction, () => initialState) // Needed for when `PopupReply` is cancelled | |||
There was a problem hiding this comment.
Should we support a flow where the user cancels their reply but wants to continue working with the existing drawing? Otherwise they'd need to start over again.
There was a problem hiding this comment.
I asked this question to product and they said that for now a cancel would start over
jstoffan
reviewed
Dec 9, 2020
ConradJChan
force-pushed
the
popover-toolbar
branch
from
b297eca to
fb88112
Compare
ConradJChan
commented
Dec 9, 2020
ConradJChan
force-pushed
the
popover-toolbar
branch
from
fb88112 to
91bafbc
Compare
jstoffan
reviewed
Dec 9, 2020
mxiao6
reviewed
Dec 10, 2020
ConradJChan
force-pushed
the
popover-toolbar
branch
from
86662ca to
0d1cb65
Compare
jstoffan
previously approved these changes
Dec 10, 2020
jstoffan
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: