Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mentions): Fix collabs list scrolling via keys #532

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix(mentions): Fix collabs list scrolling via keys #532

merged 2 commits into from
Jun 29, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jun 24, 2020 •
edited
Loading

  • Unit Test

jstoffan
jstoffan reviewed Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach LGTM, just some minor optimizations

src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemRow.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemRow.tsx Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the fix-mentions-scroll branch 2 times, most recently from 7403a35 to 2224ff1 Compare June 24, 2020 20:57
jstoffan
jstoffan reviewed Jun 24, 2020
View reviewed changes
src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
@mxiao6 mxiao6 marked this pull request as ready for review June 24, 2020 22:40
@mxiao6 mxiao6 requested a review from a team as a code owner June 24, 2020 22:40
@mxiao6 mxiao6 force-pushed the fix-mentions-scroll branch from 8d1c35b to 4e02b30 Compare June 26, 2020 17:59
jstoffan
jstoffan reviewed Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need some tests for the new behaviors.

src/components/ItemList/ItemList.tsx Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the fix-mentions-scroll branch from 4e02b30 to a570941 Compare June 26, 2020 21:01
@mergify mergify bot merged commit ed6cab6 into box:master Jun 29, 2020
@mxiao6 mxiao6 deleted the fix-mentions-scroll branch August 12, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxiao6 @jstoffan @ConradJChan