Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mentions): Server-side filtering #520

Merged
merged 1 commit into from
Jun 18, 2020
Merged

feat(mentions): Server-side filtering #520

merged 1 commit into from
Jun 18, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Jun 17, 2020 •
edited
Loading

  • Merge Conflicts
  • Tests

@mxiao6 mxiao6 force-pushed the mentions-server branch from 2226b21 to 554b7ef Compare June 17, 2020 22:36
jstoffan
jstoffan reviewed Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good.

src/components/ReplyField/ReplyField.tsx Outdated Show resolved Hide resolved
src/components/ReplyField/ReplyField.tsx Outdated Show resolved Hide resolved
src/components/ReplyField/ReplyFieldContainer.tsx Outdated Show resolved Hide resolved
src/constants.js Outdated Show resolved Hide resolved
src/store/users/actions.ts Outdated Show resolved Hide resolved
@mxiao6 mxiao6 marked this pull request as ready for review June 17, 2020 23:31
@mxiao6 mxiao6 requested a review from a team as a code owner June 17, 2020 23:31
@mxiao6 mxiao6 force-pushed the mentions-server branch from 0360778 to b7b9cf1 Compare June 17, 2020 23:32
jstoffan
jstoffan previously approved these changes Jun 18, 2020
View reviewed changes
src/components/ReplyField/ReplyFieldContainer.tsx Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the mentions-server branch from b7b9cf1 to aa79b28 Compare June 18, 2020 00:10
@mergify mergify bot merged commit fa96a3b into box:master Jun 18, 2020
@mxiao6 mxiao6 deleted the mentions-server branch August 12, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxiao6 @jstoffan