feat(active): emit annotations_active_change with fileVersionId #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoffan
previously approved these changes
Jun 5, 2020
|
|
||
| if (prevActiveAnnotationId !== nextActiveAnnotationId) { | ||
| eventManager.emit(Event.ACTIVE_CHANGE, nextActiveAnnotationId); | ||
| eventManager.emit(Event.ACTIVE_CHANGE, { annotationId: nextActiveAnnotationId, fileVersionId }); |
There was a problem hiding this comment.
Looks like a breaking change. Do you plan to merge/release both this and BUIE at the same time?
There was a problem hiding this comment.
Yeah, will need to bump both at the same time
jstoffan
reviewed
Jun 10, 2020
jstoffan
previously approved these changes
Jun 10, 2020
ConradJChan
force-pushed
the
active-annotation-file-version-id
branch
from
62b790c to
086e456
Compare
jstoffan
previously approved these changes
Jun 10, 2020
ConradJChan
force-pushed
the
active-annotation-file-version-id
branch
from
bbf4e3c to
c65bad8
Compare
jstoffan
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotations_active_changeevent to send the annotatedfileVersionIdalong with theannotationIdfileOptions.<fileId>.fileVersionIdover thefile.file_version.id