Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(region): Retain annotation message between pages #498

Merged
merged 3 commits into from
May 27, 2020
Merged

feat(region): Retain annotation message between pages #498

merged 3 commits into from
May 27, 2020

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented May 23, 2020

No description provided.

@mxiao6 mxiao6 requested a review from a team as a code owner May 23, 2020 00:17
jstoffan
jstoffan reviewed May 23, 2020
View reviewed changes
src/region/RegionAnnotations.tsx Outdated Show resolved Hide resolved
src/region/RegionAnnotations.tsx Outdated Show resolved Hide resolved
src/region/RegionAnnotations.tsx Outdated Show resolved Hide resolved
src/region/RegionCreator.tsx Outdated Show resolved Hide resolved
src/region/RegionContainer.tsx Outdated Show resolved Hide resolved
src/region/RegionAnnotations.tsx Outdated Show resolved Hide resolved
src/region/__tests__/RegionCreator-test.tsx Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the retain-message branch 5 times, most recently from 208b4c9 to c28d0c7 Compare May 27, 2020 05:57
jstoffan
jstoffan reviewed May 27, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like more fundamental changes to the reducer would simplify this a lot.

src/region/RegionCreator.tsx Outdated Show resolved Hide resolved
src/region/RegionCreator.tsx Outdated Show resolved Hide resolved
src/region/RegionCreator.tsx Outdated Show resolved Hide resolved
src/region/RegionCreator.scss Outdated Show resolved Hide resolved
src/store/creator/types.ts Outdated Show resolved Hide resolved
src/store/creator/selectors.ts Outdated Show resolved Hide resolved
src/store/creator/reducer.ts Outdated Show resolved Hide resolved
src/store/creator/actions.ts Outdated Show resolved Hide resolved
src/region/__tests__/RegionAnnotations-test.tsx Show resolved Hide resolved
jstoffan
jstoffan reviewed May 27, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new approach is nice refinement.

src/region/RegionCreator.tsx Outdated Show resolved Hide resolved
src/store/creator/__tests__/reducer-test.ts Outdated Show resolved Hide resolved
src/store/creator/reducer.ts Outdated Show resolved Hide resolved
src/store/creator/selectors.ts Outdated Show resolved Hide resolved
@mergify mergify bot merged commit f4553f7 into box:master May 27, 2020
@mxiao6 mxiao6 deleted the retain-message branch August 13, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConradJChan ConradJChan ConradJChan left review comments

@jstoffan jstoffan jstoffan approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxiao6 @jstoffan @ConradJChan