Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(activeannotation): apply activeId to existing annotation #435

Merged
merged 4 commits into from
Apr 17, 2020
Merged

feat(activeannotation): apply activeId to existing annotation #435

merged 4 commits into from
Apr 17, 2020

Conversation

ConradJChan
Copy link
Contributor

@ConradJChan ConradJChan commented Apr 16, 2020 •
edited
Loading

Todo:

  • unit tests

@ConradJChan ConradJChan requested a review from a team as a code owner April 16, 2020 22:25
jstoffan
jstoffan reviewed Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after tests. 👍

src/region/RegionContainer.tsx Outdated Show resolved Hide resolved
mxiao6
mxiao6 previously approved these changes Apr 16, 2020
View reviewed changes
jstoffan
jstoffan requested changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@jstoffan jstoffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dates should be changed to constants to avoid issues with unit tests.

@ConradJChan ConradJChan merged commit 990a6ac into box:master Apr 17, 2020
@ConradJChan ConradJChan deleted the apply-active-id branch April 17, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstoffan jstoffan jstoffan approved these changes

@mxiao6 mxiao6 mxiao6 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConradJChan @jstoffan @mxiao6