New: Add plain highlight functional tests #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @pramodsum has signed the CLA. Thanks for the pull request! |
DanDeMicco
reviewed
Apr 12, 2018
functional-tests/helpers/canvas.js
Outdated
| * @return {void} | ||
| */ | ||
| function confirmAnnotationOnCanvas(I, selector) { | ||
| const isBlankCanvas = I.executeScript((sel) => { |
There was a problem hiding this comment.
I believe you will have problems with arrow functions on IE
pramodsum
force-pushed
the
highlight_test
branch
2 times, most recently
from
a267e3b to
6bd43ad
Compare
- Move more CSS selectors to consts
pramodsum
force-pushed
the
highlight_test
branch
from
6bd43ad to
29b7d9d
Compare
JustinHoldstock
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.