fix(basemanager): Replace remove method that is unsupported in IE11 (#…

…679)
box · Feb 3, 2021 · f0fd58e · f0fd58e
1 parent 1920e3a
commit f0fd58e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/common/BaseManager.ts b/src/common/BaseManager.ts
@@ -45,7 +45,10 @@ export default class BaseManager implements Manager {
     destroy(): void {
         ReactDOM.unmountComponentAtNode(this.reactEl);
 
-        this.reactEl.remove();
+        const parentEl = this.reactEl.parentNode;
+        if (parentEl) {
+            parentEl.removeChild(this.reactEl);
+        }
     }
 
     exists(parentEl: HTMLElement): boolean {

diff --git a/src/common/__tests__/BaseManager-test.ts b/src/common/__tests__/BaseManager-test.ts
@@ -1,5 +1,7 @@
+import * as ReactDOM from 'react-dom';
 import BaseManager, { Options, Props } from '../BaseManager';
 
+jest.mock('react-dom');
 class TestBaseManager extends BaseManager {
     // eslint-disable-next-line @typescript-eslint/no-empty-function
     decorate(): void {}
@@ -38,4 +40,15 @@ describe('BaseManager', () => {
             expect(wrapper.reactEl.getAttribute('data-resin-foo')).toBe('bar');
         });
     });
+
+    describe('destroy()', () => {
+        test('should unmount and remove node', () => {
+            const removeChildSpy = jest.spyOn(rootEl, 'removeChild');
+            const wrapper = getWrapper();
+            wrapper.destroy();
+
+            expect(ReactDOM.unmountComponentAtNode).toHaveBeenCalledWith(wrapper.reactEl);
+            expect(removeChildSpy).toHaveBeenCalledWith(wrapper.reactEl);
+        });
+    });
 });