Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should BoutDataset.save() record the version of xBOUT used to produce the files? #244

Open
johnomotani opened this issue Sep 1, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@johnomotani
Copy link
Collaborator

Might be useful for provenance tracking and reproducibility to know what version of xBOUT was used to produce some file. Similar to boutproject/boutdata#79.

@johnomotani johnomotani added the enhancement New feature or request label Sep 1, 2022
@ZedThree
Copy link
Member

ZedThree commented Sep 2, 2022

Oh, I perhaps should've thought about this on that other PR, it would be good to have this set of metadata as attributes:

  • title
  • software_name
  • software_version
  • netcdf_version
  • date_created
  • id

I've cobbled this set together from various conventions, including netCDF and the Climate Forcasting conventions, and I've been trying to get it into various output files.

I think we might already have some of these?

@bendudson
Copy link
Contributor

Quick bikeshedding question: Should software_version be a semantic or at least sequential version number, or a git checksum, or a combination?

@ZedThree
Copy link
Member

ZedThree commented Sep 5, 2022

Yes :)

Personally, I'm a big fan of setuptools_scm's scheme, which is SemVer compatible. It's basically:

  • no distance and clean:
    {tag}
  • distance and clean:
    {next_version}.dev{distance}+{scm letter}{revision hash}

So a release would be 1.2.3 say, and the first commit after that would get version 1.2.3.dev1+gdeadbeef

@johnomotani
Copy link
Collaborator Author

👍 I was gonna say what @ZedThree said.

@dschwoerer
Copy link
Contributor

Offtopic: Isn't the next one 1.2.4.dev1+gdeadbeef?

@ZedThree
Copy link
Member

Good catch, yes. I think there's some setting to make it bump the minor version instead too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants