Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poloidal_plot argument for plot2d_wrapper #167

Open
johnomotani opened this issue Nov 12, 2020 · 0 comments
Open

poloidal_plot argument for plot2d_wrapper #167

johnomotani opened this issue Nov 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@johnomotani
Copy link
Collaborator

It would be nice to have a poloidal_plot argument to plot2d_wrapper() (and so for BoutDataArray.pcolormesh(), BoutDataArray.contour() and BoutDataArray.contourf()) like animate2D() and animate_list() have so that we can turn off the poloidal plot feature and just plot any simple slice of the data. We've got a few extra features (e.g. simple log-scaling of the colorbar) compared to the base xarray methods that would be nice to have. Needs a bit of restructuring of plot2d_wrapper() to not always use regions.

Question is what the sensible default value for poloidal_plot would be. I think my ideal solution would be: True if spatial dimensions are the ones corresponding to bout_xdim and bout_ydim and the DataArray has regions (i.e. if a poloidal_plot is possible); and False otherwise. That is different from animate2D() and animate_list() (which default to poloidal_plot=False) - I'd favour updating them to have this default behaviour. It would keep the current behaviour of plot2d_wrapper() for cases that it can currently plot.

@johnomotani johnomotani added the enhancement New feature or request label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant