Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing attributes #155

Open
johnomotani opened this issue Oct 2, 2020 · 0 comments
Open

Testing attributes #155

johnomotani opened this issue Oct 2, 2020 · 0 comments
Labels
testing Involves writing or running unit, integrated, or regression tests

Comments

@johnomotani
Copy link
Collaborator

When a new version of boutdata is released (0.1.3), we should be able to use assert_identical instead of assert_equals in

def test_save_all(self, tmpdir_factory, bout_xyt_example_files):

and
@pytest.mark.parametrize("geometry", [None, "toroidal"])

because that release will add the BoutOptions.__eq__() method, which should allow all the attributes of the Dataset to pass the tests.

Might be a few other places we could update to assert_identical instead of assert_equal as well?

@johnomotani johnomotani added the testing Involves writing or running unit, integrated, or regression tests label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Involves writing or running unit, integrated, or regression tests
Projects
None yet
Development

No branches or pull requests

1 participant