-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building single packages stopped working on develop #3372
Comments
There seems to be some similar (not same) issues to be discussed on cargo upstream. I am however not quite sure on the interactions between cargo, buildsys, and twoliter. Example issues upstream: |
Running the build with
|
Running The key to understanding the error lies in the new Cargo feature resolver v2 separating activated features by both package and where/when it is going to be used. When checking for activated features of a package, Cargo takes both into account. It bails when it unexpectedly cannot find a combination of {package, where to use it}. The following is my current understanding of the matter, but it is to be taken with a
I'm not sure what would a good way to resolve this would look like. Perhaps reverting to the feature resolver v1 and accepting warnings is the lesser evil for now, so we can avoid the problem by having the unified feature namespace. |
This appears to have been resolved with #3376 and future work captured with bottlerocket-os/twoliter#45 - closing this issue. |
Platform I'm building on:
AWS c5.metal instance (x86_64)
What I expected to happen:
Build of a single package for a given variant, for example
kernel-5.10
for variantaws-k8s-1.23
What actually happened:
Getting an error where thread main of cargo (?) is panicking:
How to reproduce the problem:
Try to build a single package for a variant like, fails for any package I have tried:
The offending commit where it all starts breaking seems to be 3a4dadc
I am not quite sure what is happening. Trying to chase the path where this is breaking is slow for me as I am not deeply familiar with cargo intricacies.
As a saving grace: Building full variants is not affected by this issue. Confirmed with @markusboehme that this is not just my dev host, and is affecting his dev environment as well.
The text was updated successfully, but these errors were encountered: