Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] language (i18n) #1

Open
1 of 3 tasks
4thabang opened this issue Jun 10, 2023 · 4 comments
Open
1 of 3 tasks

[feature] language (i18n) #1

4thabang opened this issue Jun 10, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@4thabang
Copy link

4thabang commented Jun 10, 2023

(I will add a potential issues format that you can potentially enforce as a template moving forward)

Bug, Feature or Other?

  • Bug
  • Feature
  • Other

Description:

Your application is amazing, although, it lacks proper language support. Currently I believe it is in Portuguese and a lot of people would enjoy an english variant or translation option. I believe adding other languages would be a big feat. Although, for accessibility and mass adoption, English seems like a good starting point.

Steps to reproduce if this is a bug:

N/A

Any other information:

N/A

@devguilhermy
Copy link
Contributor

Hey @4thabang, thanks a lot the template, we shall be using it from now on!

What you are saying totally makes sense but the app is in English already 🤔
The only thing in portuguese is the locale for date formatting, but you can change it easily in the code by just importing the preferred locale.

I actually started with PT but when I decided to make it open source I began translating all labels and comments. Did you find some untranslated text?

Anyway I think it's feasible to create a settings page for choosing language, timezone, theme and such.
Next week I might add that!

Thanks for starting this discussion!

@devguilhermy devguilhermy added enhancement New feature or request good first issue Good for newcomers labels Jun 11, 2023
@devguilhermy devguilhermy self-assigned this Jun 11, 2023
@4thabang
Copy link
Author

Yeah, after digging through the code a little more I found the ptBR import and simply used enUS instead.

Although, the settings page would be a nice feature for making the app more accessible.

By the way, amazing work!

@devguilhermy

@devguilhermy
Copy link
Contributor

Thanks a lot! 🙌🏽

I will keep this open until we launch the language selection feature alright?

Besides locale you can also config the format of the date with date-fns, it's pretty neat!
Check out the docs if you don't know it already 📚

Cheers

@devguilhermy devguilhermy reopened this Jun 12, 2023
@4thabang
Copy link
Author

No worries.

Just checked it out and its really cool, thank you for pointing me to it. Will definitely be using it in future projects.

Please do let me know when the language selection feature is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants