Make output JSON serializable #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.31%@@ develop #961 diff @@
==========================================
Files 43 43
Lines 7014 7014
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6826 6826
Misses 188 188
Partials 0 0
|
|
Could you please add a test for this? |
|
I'll go ahead and take this and add a test. I'd like to get this fixed asap so I'll add a test. |
|
Pulled in this PR and added a test. Let's track the remaining work in #962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9256870 breaks assumed roles in AWS CLI because it adds HTTP headers in a
botocore.vendored.requests.structures.CaseInsensitiveDict. AWS CLI caches details to disk by serializing to JSON.Resolve this by coercing into a normal dict.