Generalize container credential provider #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1160 +/- ##
===========================================
+ Coverage 97.95% 97.96% +<.01%
===========================================
Files 45 45
Lines 7093 7122 +29
===========================================
+ Hits 6948 6977 +29
Misses 145 145
Continue to review full report at Codecov.
|
You can now provide a full url in addition to a relative url. I've added hostname validation to only allow the ECS IP and localhost. Anything else results in an exception being raised.
|
You may also want to include a changelog entry before you merge. Make it an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now provide a full url in addition to a relative url to retrieve credentials.
I've added hostname validation to only allow the ECS IP and localhost.
Anything else results in an exception being raised.
cc @kyleknap @JordonPhillips @stealthycoin @dstufft
cc @jasdel