Fix a paginator bug involving optional tokens. #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug could cause the route53 list_resource_record_sets paginator to skip over a record in certain cases.
Current coverage is 97.57% (diff: 100%)@@ develop #1057 diff @@
==========================================
Files 44 44
Lines 6917 6918 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6749 6750 +1
Misses 168 168
Partials 0 0
|
kyleknap
added
pr/ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug causes the route53 list_resource_record_sets paginator to skip over records in certain cases.
list_resource_record_sets uses a 3-tuple of pagination tokens, but one of them will be absent on some records. If the second page starts with a 3-token item and the third page starts with a 2-token item, the previous third token will get left in the request parameters, causing the backend to advance past the targeted item.