Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubber: Allow add_client_error to use expected_params #1025

Closed
wants to merge 1 commit into from
Closed

Stubber: Allow add_client_error to use expected_params #1025

wants to merge 1 commit into from

Conversation

Jc2k
Copy link
Contributor

@Jc2k Jc2k commented Sep 1, 2016

I'd like to be able to use expected_params with add_client_error - it looks like this should be enough?

@codecov-io
Copy link

codecov-io commented Sep 1, 2016

Current coverage is 97.56% (diff: 100%)

Merging #1025 into develop will decrease coverage by 0.04%

@@            develop      #1025   diff @@
==========================================
  Files            44         44          
  Lines          6870       6870          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6706       6703     -3   
- Misses          164        167     +3   
  Partials          0          0          

Powered by Codecov. Last update bbfdade...0b35b49

@kyleknap
Copy link
Contributor

kyleknap commented Sep 1, 2016

If you can add a test for this, that would be great. I would be in favor of pulling this in because I think it would be useful, but we typically need tests for the new functionality to be able to pull it in.

@jamesls
Copy link
Member

jamesls commented Sep 13, 2016

I'll go ahead and take this and add a test for it. I think this will be really useful. Assigning to myself.

@jamesls jamesls self-assigned this Sep 13, 2016
@Jc2k
Copy link
Contributor Author

Jc2k commented Sep 13, 2016

Thanks @jamesls! I've been too snowed to get to it 😭

@jamesls
Copy link
Member

jamesls commented Sep 19, 2016

Merged via #1031.

@jamesls jamesls closed this Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants