Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_response attr to WaiterError #1023

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Aug 29, 2016

The rationale behind just adding a last_response instead of exposing some sort
of error_code and error_message is that a WaiterError can also be thrown in
non-error states (transitioning to a failure state, hitting max-attempts), and
while we can always guarantee a last response, we can't necessarily guarantee
that response is a "error" response.

Closes #957

ushatil and others added 2 commits June 21, 2016 11:10
The rationale behind just adding a last_response instead of exposing some sort
of error_code and error_message is that a WaiterError can also be thrown in
non-error states (transitioning to a failure state, hitting max-attempts), and
while we can always guarantee a last response, we can't necessarily guarantee
that response is a "error" response.

Closes boto#957
@codecov-io
Copy link

Current coverage is 97.56% (diff: 100%)

Merging #1023 into develop will increase coverage by <.01%

@@            develop      #1023   diff @@
==========================================
  Files            44         44          
  Lines          6867       6870     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           6700       6703     +3   
  Misses          167        167          
  Partials          0          0          

Powered by Codecov. Last update 11ec141...3d620ad

@kyleknap
Copy link
Contributor

Looks good. I like having the last response for any potential waiter error as opposed to just errors propogated from service errors. 🚢

@jamesls jamesls added the pr/needs-review This PR needs a review from a member of the team. label Aug 29, 2016
@JordonPhillips
Copy link
Contributor

This will make debugging waiter issues much easier

___________________________________________________________________
||     *                            *                    ((   *  ||
||        *                 *                *            ~      ||
||                ___.                          *          *     ||
||       *    ___.\__|.__.           *                           ||
||            \__|. .| \_|.                                      ||
||            . X|___|___| .                         *           ||
||          .__/_||____ ||__.            *                /\     ||
||  *     .  |/|____ |_\|_ |/ _                          /  \    ||
||        \ _/ |_X__\|_  |\||~,~{                       /    \   ||
||         \/\ |/|    |_ |/:|`X'{                   _ _/      \__||
||          \ \/ |___ |_\|_.|~~~                   /    . .. . ..||
||         _|X/\ |___\|_ :| |_.                  - .......... . .||
||         | __\_:____ |  ||o-|            ___/........ . . .. ..||
||         |/_-|-_|__ \|_ |/--|       ____/  . . .. . . .. ... . ||
|| ........:| -|- o-o\_:_\|o-/:....../...........................||
|| ._._._._._\=\====o==o==o=/:.._._._._._._._._._._._._._._._._._||
|| _._._._._._\_\ ._._._._.:._._._._._._._._._._._._._.P_._._._._||
|| ._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._._||
||---------------------------------------------------------------||

@jamesls jamesls merged commit 3d620ad into boto:develop Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/needs-review This PR needs a review from a member of the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants