Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clojure.java.browse/browse-url #495

Closed
borkdude opened this issue Jun 22, 2020 · 2 comments · Fixed by #496
Closed

add clojure.java.browse/browse-url #495

borkdude opened this issue Jun 22, 2020 · 2 comments · Fixed by #496

Comments

@borkdude
Copy link
Collaborator

As discussed on Slack:

@lread I would be open to a PR that adds clojure.java.browse/browse-url, but only shells out and doesn't use the reflection or swing stuff. (edited)
So our own stripped down implementation of it.

@lread
Copy link
Contributor

lread commented Jun 22, 2020

A note from lukasz on Slack:

@lread FWIW - open and xdg-open do all of this for you in OSX and Linux respectively, so could be just a one-liner. No idea about Windows

@borkdude
Copy link
Collaborator Author

borkdude commented Jun 22, 2020

The Windows equivalent of open/xdg-open is probably start on Windows. The clojure.java.browse namespace has also some logic for Cygwin, but I'm not sure how relevant this is in 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants