Skip to content

Commit

Permalink
Change compose box inputs from controlled to 'not controlled'
Browse files Browse the repository at this point in the history
Fixes zulip#2589

Now both message and topic inputs are updated regardless of wether
they are controlled or not we remove the `value={...}`.
  • Loading branch information
borisyankov committed Jun 27, 2018
1 parent b572df5 commit f386f9a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/compose/ComposeBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ class ComposeBox extends PureComponent<Props, State> {
onFocus={this.handleTopicFocus}
onBlur={this.handleTopicBlur}
onTouchStart={this.handleInputTouchStart}
value={topic}
/>
)}
<MultilineInput
Expand All @@ -347,7 +346,6 @@ class ComposeBox extends PureComponent<Props, State> {
messageInputRef(component);
}
}}
value={message}
onBlur={this.handleMessageBlur}
onChange={this.handleMessageChange}
onFocus={this.handleMessageFocus}
Expand Down

0 comments on commit f386f9a

Please sign in to comment.