Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw error if the matched keyword is commented #1

Open
borisguery opened this issue Jan 8, 2013 · 2 comments
Open

Don't throw error if the matched keyword is commented #1

borisguery opened this issue Jan 8, 2013 · 2 comments

Comments

@borisguery
Copy link
Owner

We may need to add a configuration to determine if we want to strictly match commented keywords.

// var_dump($dummy);

It may not be matched based on flag.

@hkdobrev
Copy link
Contributor

You don't need comments like that in your commits. If I really, really do want to commit comments like that I would use the --no-verifiy option flag.

@borisguery
Copy link
Owner Author

@hkdobrev, that's right, the problem is I may want to strictly check for some keyword while accepting those which are commented.

In development phase, it is sometimes useful to let a commented log. That's why I think a flag would be nice to avoid a two step process (first commit, then add the --no-verify option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants