Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two failing unit tests w.r.t. MVS utilities #413

Open
johnwlambert opened this issue Dec 22, 2021 · 0 comments
Open

Fix two failing unit tests w.r.t. MVS utilities #413

johnwlambert opened this issue Dec 22, 2021 · 0 comments

Comments

@johnwlambert
Copy link
Collaborator

Two tests are failing currently: TestEllipsoidUtils.test_get_right_singular_vectors and TestPatchmatchNetData.test_select_src_views.

The first is due to the fact that we aren't returning singular values, so we need to correct the terminology. The other test looks like it is flaky due to some random ordering of the output.

>       assert np.allclose(singular_values, S)
E       AssertionError: assert False
E        +  where False = <function allclose at 0x7fefe2b41f70>(array([7.73928148, 2.82711821, 1.20177289]), array([13.40482874,  4.89671238,  2.08153171]))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant