Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchFixedLagSmoother::marginalCovariance #1903

Open
chrisflesher opened this issue Nov 18, 2024 · 0 comments
Open

BatchFixedLagSmoother::marginalCovariance #1903

chrisflesher opened this issue Nov 18, 2024 · 0 comments

Comments

@chrisflesher
Copy link

chrisflesher commented Nov 18, 2024

Feature

I couldn't access BatchFixedLagSmoother function marginalCovariance in python (using pip install gtsam==4.2). It seems this is because it is not implemented in C++ either:

Matrix BatchFixedLagSmoother::marginalCovariance(Key key) const {
  throw runtime_error(
      "BatchFixedLagSmoother::marginalCovariance not implemented");
}

Motivation

This functionality seems necessary for real-time estimation and easy to implement.

Pitch

It would be nice to get new python version with this.

Alternatives

IncrementalFixedLagSmoother seems like a decent alternative?

@chrisflesher chrisflesher changed the title Add python binding for BatchFixedLagSmoother marginalCovariance Add python binding for BatchFixedLagSmoother marginal covariance Nov 18, 2024
@chrisflesher chrisflesher changed the title Add python binding for BatchFixedLagSmoother marginal covariance Add python BatchFixedLagSmoother marginal covariance Nov 18, 2024
@chrisflesher chrisflesher changed the title Add python BatchFixedLagSmoother marginal covariance Add python binding for BatchFixedLagSmoother marginalCovariance Nov 18, 2024
@chrisflesher chrisflesher changed the title Add python binding for BatchFixedLagSmoother marginalCovariance Add python binding for marginalCovariance Nov 18, 2024
@chrisflesher chrisflesher reopened this Nov 18, 2024
@chrisflesher chrisflesher changed the title Add python binding for marginalCovariance Add python BatchFixedLagSmoother marginalCovariance Nov 18, 2024
@chrisflesher chrisflesher changed the title Add python BatchFixedLagSmoother marginalCovariance Add BatchFixedLagSmoother marginalCovariance Nov 18, 2024
@chrisflesher chrisflesher changed the title Add BatchFixedLagSmoother marginalCovariance BatchFixedLagSmoother marginalCovariance Nov 19, 2024
@chrisflesher chrisflesher changed the title BatchFixedLagSmoother marginalCovariance BatchFixedLagSmoother::marginalCovariance Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant