From 733e919570159e18cc49f524598ff6a1a2ed72ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Gonzalve?= <sebastien.github@gonzalve.net>
Date: Sat, 9 Nov 2024 20:20:37 +0100
Subject: [PATCH] Make operator-> const

Having this operator non-const is awkward as operator* is const. This
sometimes leads to writing:
  (*obj).data; instead of obj->data;
which is unexpected....
---
 gtsam/nonlinear/Values.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gtsam/nonlinear/Values.h b/gtsam/nonlinear/Values.h
index 21e8e281f9..2fe64d9c91 100644
--- a/gtsam/nonlinear/Values.h
+++ b/gtsam/nonlinear/Values.h
@@ -189,7 +189,7 @@ namespace gtsam {
       const_iterator_type it_;
       deref_iterator(const_iterator_type it) : it_(it) {}
       ConstKeyValuePair operator*() const { return {it_->first, *(it_->second)}; }
-      std::unique_ptr<ConstKeyValuePair> operator->() {
+      std::unique_ptr<ConstKeyValuePair> operator->() const {
         return std::make_unique<ConstKeyValuePair>(it_->first, *(it_->second));
       }
       bool operator==(const deref_iterator& other) const {