show_progress: add finished=true/false to archive_progress json #6683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…borgbackup#6570 also: - remove empty values from final json - add test
Codecov Report
@@ Coverage Diff @@
## 1.2-maint #6683 +/- ##
=============================================
+ Coverage 82.81% 82.99% +0.18%
=============================================
Files 38 38
Lines 10497 10503 +6
Branches 2059 2060 +1
=============================================
+ Hits 8693 8717 +24
+ Misses 1287 1271 -16
+ Partials 517 515 -2
Continue to review full report at Codecov.
|
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jul 1, 2022
…up#4074 in the finished == true message, these are missing: - message - current / total - info This is to be somewhat consistent with borgbackup#6683 by only providing a minimal set of values for the finished case. The finished messages is primarily intended for cleanup purposes, e.g. clearing the progress display.
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jul 1, 2022
…up#4074 in the finished == true message, these are missing: - message - current / total - info This is to be somewhat consistent with borgbackup#6683 by only providing a minimal set of values for the finished case. The finished messages is primarily intended for cleanup purposes, e.g. clearing the progress display.
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jul 1, 2022
…up#4074 in the finished == true message, these are missing: - message - current / total - info This is to be somewhat consistent with borgbackup#6683 by only providing a minimal set of values for the finished case. The finished messages is primarily intended for cleanup purposes, e.g. clearing the progress display.
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Jul 1, 2022
…up#4074 in the finished == true message, these are missing: - message - current / total - info This is to be somewhat consistent with borgbackup#6683 by only providing a minimal set of values for the finished case. The finished messages is primarily intended for cleanup purposes, e.g. clearing the progress display.
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6570
also: