Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: "Edit on GitHub" link broken #689

Closed
dannyedel opened this issue Feb 22, 2016 · 1 comment
Closed

Documentation: "Edit on GitHub" link broken #689

dannyedel opened this issue Feb 22, 2016 · 1 comment

Comments

@dannyedel
Copy link
Contributor

In the online documentation, the "Edit on GitHub" (top right corner) link appears to be broken.

Example link:

https://borgbackup.readthedocs.org/en/stable/installation.html refers to https://github.com/borgbackup/borg/blob/ec547402300e53728fb53bc20732049e63ef29c3/docs/installation.rst which is 404.

On my local clone, this is the sha of the gpg-signed tag object, not of the underlying commit, which is cd6044e.

The latest branch does not have this issue (it hardcodes "master" into the pathname).

Possible fix: If I use the tag's name instead of the sha, the link works as intended:

https://github.com/borgbackup/borg/blob/0.30.1/docs/installation.rst

If it's not possible to change the link target, then maybe disable the link on release builds, a 404 helps nobody to contribute.

@ThomasWaldmann
Copy link
Member

The problem is known, but IIRC this is part of the readthedocs theme, not of our content/code.

Duplicate of #451 and #413. Issue is tracked there: readthedocs/readthedocs.org#1820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants