Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use blake2 from python and drop our stuff? #5634

Closed
Tracked by #5635
ThomasWaldmann opened this issue Jan 18, 2021 · 1 comment
Closed
Tracked by #5635

use blake2 from python and drop our stuff? #5634

ThomasWaldmann opened this issue Jan 18, 2021 · 1 comment
Assignees
Milestone

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Jan 18, 2021

master branch has a minimum requirement of python 3.6.

As @enkore already noted in #1044 :

Python 3.6 will include BLAKE2 with a comprehensive API: https://docs.python.org/3.6/library/hashlib.html#blake2

TODO:

  • check if we can use it via Python and drop our bundled code / our libb2 requirement / our own wrapper.
  • we must have unit tests that make sure both implementations actually yield same hash/mac values.
  • use blake2 functions via Python

Bounty: https://www.bountysource.com/issues/96027662-use-blake2-from-python-and-drop-our-stuff

@ThomasWaldmann
Copy link
Member Author

fixed by #5647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant