-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object's fields have suspicious color #176
Comments
Also I found same issue in the babel repo: |
This was intentionally, Naomi marks then as:
While the native syntax only does:
This was intentional in Naomi because it keeps the syntax compatible with most color schemes that like Candyman gives a different color to object literal keys, in fact, on the build system's branch I changed the keys colors to a light brown to distinguish better the key from types in code that has a lot of Flow annotations: The way the native syntax scopes the keys, makes it imposible to color it without affecting other key types. |
If you add a rule to your color scheme targeting the scopes:
You'll be able to use any color in there without the risk of affecting the values. |
So it's more like monokai's issue. |
No problem, if you have any questions, feel free to open new issue reports :D |
test code:
first lets look at native JS syntax
monokai:
candyman:
field names are nearly white, let's say it's a basic text color
And this is Naomi
monokai:
candyman:
in monokai it same as string constants
in candyman I am not sure what does this color mean.
Was this made intentionally?
In monokai this looks not very good with large objects filled with strings:
everything is yellow, not very readable.
The text was updated successfully, but these errors were encountered: