#58 Fix a bug when attempting to migrate pom files with no build sect… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inputLocation = new InputLocation(referenceLocation.getLineNumber() + 1, referenceLocation.getColumnNumber()); | ||
| line = "\t\t<directory>dist</directory>\n"; | ||
| } else { | ||
| InputLocation referenceLocation = model.getLocation("packaging"); |
There was a problem hiding this comment.
A: This feels like the wrong location given the test POM and our usual layout in our MDA templates. Makes more sense to me to do it before dependencies at the very end before the </project> line. The former feels a bit more natural, but the latter is less complex as dependencies could be missing.
…uild section. Signed-off-by: Peter McClonski <[email protected]>
peter-mcclonski
force-pushed
the
58-fix-null-pointer
branch
from
60c67c8
to
3499bee
Compare
ewilkins-csi
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion.