#28 Change credentials for LocalStack between environments without replicating all of my environment properties #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carter-cundiff
force-pushed
the
28-localstack-credential-refactor
branch
from
aef9c3e
to
efd98bc
Compare
ewilkins-csi
reviewed
May 9, 2024
extensions/extensions-docker/aissemble-spark/src/main/resources/docker/Dockerfile
Show resolved
Hide resolved
ewilkins-csi
reviewed
May 9, 2024
extensions/extensions-helm/aissemble-localstack-chart/templates/credential-secret.yaml
Outdated
Show resolved
Hide resolved
ewilkins-csi
reviewed
May 9, 2024
|
|
||
| // check that the base values file contains localstack configuration | ||
| if (hasLocalstackConfig(baseValuesObject.getDriverEnvs()) && | ||
| hasLocalstackConfig(baseValuesObject.getExecutorEnvs())) { |
There was a problem hiding this comment.
S: It's conceivable that the executor config has been removed but it's still set on the driver. Since we use dynamic allocation, a project may not be spinning up executors during local development and so only have the localstack config on the driver.
There was a problem hiding this comment.
Changed logic to accommodate for either executor or driver having the hardcoded localstack credentials. Created new BDD scenarios to test.
ewilkins-csi
approved these changes
May 9, 2024
carter-cundiff
force-pushed
the
28-localstack-credential-refactor
branch
2 times, most recently
from
7189b19
to
2711083
Compare
…plicating all of my environment properties
carter-cundiff
force-pushed
the
28-localstack-credential-refactor
branch
from
2711083
to
5903854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.