Update to 1.11.0-SNAPSHOT #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilkins-csi
commented
Nov 20, 2024
| @@ -45,10 +45,6 @@ jobs: | |||
| with: | |||
| gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | |||
| passphrase: ${{ secrets.GPG_PRIVATE_KEY_PASSPHRASE }} | |||
| - name: Install git | |||
There was a problem hiding this comment.
I: This was already being done in the install_dependencies step
ewilkins-csi
commented
Nov 20, 2024
test/src/test/resources/README.md
Outdated
There was a problem hiding this comment.
I: Removed this after discussion with the team. This test wasn't really adding much and it required manual changes before/after every release to update the version in the Dockerfile and Chart.yaml.
ewilkins-csi
force-pushed
the
aissemble-release-1.10
branch
from
8d4a2b4
to
be5511d
Compare
csun-cpointe
approved these changes
Nov 20, 2024
Closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares for development of 1.11 by:
Also removes the
test/srcdirectory and cleans up some redundancy in the release job. For justification of the former see PR comments below.