#23 As a data engineer, I want the default memory for Spark ap… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should remove AIOPS-3232 from the PR title and commit message. Only reference the issue number associated with this ticket. So your commit message should be "#23 As a data engineer..." |
tianliang0038
changed the title
Due to some tricky ordering of exclusions in our .gitignore file many of the test files for the mda-maven-plugin were ignored during our initial migration. Moved nearly all exclusions to the tail of the .gitignore file to prevent future mishaps except one instance where the ordering was clearly intentional. Also removed .gitignore from the ignored list so updates to it are easily picked up.
…plications to be increased so it works out of the box for more than just toy examples
tianliang0038
force-pushed
the
23-update-default-memory-for-spark
branch
from
cc390f1
to
52b1f80
Compare
There was a problem hiding this comment.
Did you mean to change this image?
| private SparkMemoryUpgradeMigration sparkmigration; | ||
| @Given("a project that has a spark application") | ||
| public void a_project_that_has_spark_application() { | ||
| assertTrue("The project has a Spark application", true); |
There was a problem hiding this comment.
This can be removed, you can have unimplemented functions in your test
aaron-gary
added a commit
that referenced
this pull request
May 2, 2024
# This is the 1st commit message: # This is a combination of 4 commits. # This is the 1st commit message: #2 Add Maven build workflow # This is the commit message #2: #2 update build workflow # This is the commit message #3: #2 add branch checkout to build workflow # This is the commit message #4: #2 Add on event to build workflow # This is the commit message #2: #2 Remove unused executions # This is the commit message #3: #2 Focus on build # This is the commit message #4: #2 Remove build execution where not needed # This is the commit message #5: #2 debug failing module # This is the commit message #6: #2 Remove unused target folder copy # This is the commit message #7: #2 Build spark and jenkins docker images # This is the commit message #8: #2 Retry full build # This is the commit message #9: #2 Omitting module # This is the commit message #10: #2 Fix for out of disk space # This is the commit message #11: #2 tagging docker images # This is the commit message #12: #2 Remove Temporarily remove Docker module # This is the commit message #13: #2 Build update # This is the commit message #14: #2 Build update # This is the commit message #15: #2 move chart dry-runs to IT profile # This is the commit message #16: #2 curl delta-hive assembly in docker build # This is the commit message #17: #2 cache m2 repo # This is the commit message #18: #2 prune docker build cache between images to save space # This is the commit message #19: #2 add maven build-cache to GH cache # This is the commit message #20: #2 run clean goal in build to clear docker cache # This is the commit message #21: #2 set maven caches to always save even if the build failed # This is the commit message #22: #2 adjust number of docker modules built # This is the commit message #23: #2 use the same cache for .m2 even if poms change # This is the commit message #24: #2 change from `save-always` flag to `if: always()` see actions/cache#1315 # This is the commit message #25: #2 further reduce docker images being built # This is the commit message #26: #2 disable modules that depend on helm charts # This is the commit message #27: #2 use maven wrapper # This is the commit message #28: #2 restore modules to test build-cache # This is the commit message #29: #2 fix build of modules with intra-project chart dependencies # This is the commit message #30: #2 use explict .m2 repo cache so we can fall-back to older caches # This is the commit message #31: #2 save maven caches on build failure
aaron-gary
added a commit
that referenced
this pull request
May 2, 2024
# This is the 1st commit message: # This is a combination of 4 commits. # This is the 1st commit message: #2 Add Maven build workflow # This is the commit message #2: #2 update build workflow # This is the commit message #3: #2 add branch checkout to build workflow # This is the commit message #4: #2 Add on event to build workflow # This is the commit message #2: #2 Remove unused executions # This is the commit message #3: #2 Focus on build # This is the commit message #4: #2 Remove build execution where not needed # This is the commit message #5: #2 debug failing module # This is the commit message #6: #2 Remove unused target folder copy # This is the commit message #7: #2 Build spark and jenkins docker images # This is the commit message #8: #2 Retry full build # This is the commit message #9: #2 Omitting module # This is the commit message #10: #2 Fix for out of disk space # This is the commit message #11: #2 tagging docker images # This is the commit message #12: #2 Remove Temporarily remove Docker module # This is the commit message #13: #2 Build update # This is the commit message #14: #2 Build update # This is the commit message #15: #2 move chart dry-runs to IT profile # This is the commit message #16: #2 curl delta-hive assembly in docker build # This is the commit message #17: #2 cache m2 repo # This is the commit message #18: #2 prune docker build cache between images to save space # This is the commit message #19: #2 add maven build-cache to GH cache # This is the commit message #20: #2 run clean goal in build to clear docker cache # This is the commit message #21: #2 set maven caches to always save even if the build failed # This is the commit message #22: #2 adjust number of docker modules built # This is the commit message #23: #2 use the same cache for .m2 even if poms change # This is the commit message #24: #2 change from `save-always` flag to `if: always()` see actions/cache#1315 # This is the commit message #25: #2 further reduce docker images being built # This is the commit message #26: #2 disable modules that depend on helm charts # This is the commit message #27: #2 use maven wrapper # This is the commit message #28: #2 restore modules to test build-cache # This is the commit message #29: #2 fix build of modules with intra-project chart dependencies # This is the commit message #30: #2 use explict .m2 repo cache so we can fall-back to older caches # This is the commit message #31: #2 save maven caches on build failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plications to be increased so it works out of the box for more than just toy examples