#108 vault property dao class can be injected when use the extensions-configuration-store-vault module #113
Conversation
…-configuration-store-vault module
| <exclusions> | ||
| <exclusion> | ||
| <groupId>io.quarkiverse.cucumber</groupId> | ||
| <artifactId>quarkus-cucumber</artifactId> |
There was a problem hiding this comment.
Q/S: Two thought occur to me: 1) Why are test dependencies being pulled here such that they have to be excluded, 2) why are these not the same version as is being used here (or are they being removed for some other reason)?
There was a problem hiding this comment.
Yeah.. the foundation-configuration-store module needs these two packages for its tests (quarkus-cucumber test), and, for this module, we don't need to start up a webserver so we don't need the quarkus-cucumber test. Also, these two transitive dependencies are causing this module's cucumber testing not being detected because of version conflicts.
| @@ -31,7 +31,7 @@ | |||
|
|
|||
| <properties> | |||
| <!-- Overriding cucumber version to align with quarkus-cucumber --> | |||
| <version.cucumber>7.4.1</version.cucumber> | |||
| <version.cucumber>${version.quarkus.cucumber.java}</version.cucumber> | |||
There was a problem hiding this comment.
A: Can't we just just inline the reference to version.quarkus.cucumber.java?
There was a problem hiding this comment.
there is no inline reference in this module. This is an overwrite of the parent property definition.
Ref: #108