Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Helm chart file:// dependencies are not packaged completely #275

Open
cwoods-cpointe opened this issue Aug 15, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@cwoods-cpointe
Copy link
Contributor

Description

Building Helm charts can fail when they have a local file:// dependency that is not built at the same time.
When the parent helm chart creates a values file from a values template as part of the build, this file will not exist if it is not build due to caching. When the child chart updates it dependencies and retrieves the parent, the values file will not be there. This can be assumed to happen for any file that's not in the chart pre-build phase.

This can happen in CI/CD instances where the workspace is pruned so the generated files during the build are not present. If the parents build is skipped because of caching and the child's is not, it will fail.

Steps to Reproduce

  1. Delete the quarkus-chart values.yaml file - rm -rf extensions/extensions-helm/aissemble-quarkus-chart/values.yaml
  2. Build dependent charts without cache
  3. mvn clean install -Dmaven.build.cache.enabled=false -pl :aissemble-configuration-store-chart
  4. mvn clean install -Dmaven.build.cache.enabled=false -pl :aissemble-data-access-chart
  5. Lint will fail
  6. Viewing the charts tars extensions/extensions-helm/aissemble-configuration-store-chart/charts/aissemble-quarkus-chart-1.0.0.tgz and /Users/cwoods/workspace/aissemble/extensions/extensions-helm/aissemble-data-access-chart/charts/aissemble-quarkus-chart-1.0.0.tgz will show no values.yaml file present

Expected Behavior

The build should succeed in pulling the quarkus dependency.
This pulled tar should contain all necessary files.

Actual Behavior

The pulled quarkus dependency does not contain the values.yaml file.
Helm chart linting fails

Additional Context

N/A

@cwoods-cpointe cwoods-cpointe added the bug Something isn't working label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant