[CLOSED] Shortcut for createLink

[Waxolunist]

Issue by brandonhilkert
Monday Jun 23, 2014 at 18:05 GMT
Originally opened as Waxolunist/bootstrap3-wysihtml5-bower#61

---

Hey! I'm using the Rails version of the plug (https://github.com/Nerian/bootstrap-wysihtml5-rails) and am looking to add a shortcut for creating a link (Cmd-K):

I added:

      shortcuts:
        "55": "insertOrderedList"
        "56": "insertUnorderedList"
        "75": "createLink"

When I hit cmd-k, it pastes a link and doesn't trigger the link modal. Should I be targeting a different action? I briefly looked through the code and the action for the button is the same as the command in the config ("createLink").

First action is me hitting the toolbar, second is Cmd-k.

[Waxolunist]

Comment by Waxolunist
Monday Jun 23, 2014 at 19:27 GMT

---

That's right. The command triggers the createLink command but the argument to this command call is missing, thats because you see the default link. There is actually not a command for opening the modal.
The link you see is some default I am unaware of.

This would be a new feature.

[Waxolunist]

Comment by brandonhilkert
Monday Jun 23, 2014 at 19:46 GMT

---

Got it. That's fair. Thanks for the feedback.

[Waxolunist]

Comment by Waxolunist
Monday Jun 23, 2014 at 19:57 GMT

---

I scheduled it for the next release. Maybe you have some more ideas.
Usually I collect everything and make every month a release depending on the priority of the incoming issues.

[Waxolunist]

Comment by brandonhilkert
Monday Jun 23, 2014 at 19:59 GMT

---

ok cool. Nothing else here. But I'll keep it in mind as I'm moving forward. Thanks!

[Waxolunist]

Comment by Waxolunist
Monday Sep 08, 2014 at 07:02 GMT

---

Fixed. See https://github.com/Waxolunist/bootstrap3-wysihtml5-bower/blob/v0.3.0-wip/test/bs/bootstrap_editor_link_test.js#L52 for an example.