Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up multiple invert-filter regex in config.toml #430

Closed
svm-zhang opened this issue Aug 15, 2024 · 6 comments
Closed

Set up multiple invert-filter regex in config.toml #430

svm-zhang opened this issue Aug 15, 2024 · 6 comments

Comments

@svm-zhang
Copy link

Hello,

Thank you for the awesome tool.

I have a question about setting up multiple invert filter REGEX in the config.toml file. I have checked the config example in the repo, as well as other tickets of similar matter. Could you please kindly show me an example?

I have also tried to add reverse=true and iso=true in the config.toml file, as shown in the config example. It seems that reverse=true gets cancelled by adding iso=true. Again, I likely did something wrong. Would be great if you could help me. Thanks again.

Simo

@wugeer
Copy link
Contributor

wugeer commented Aug 16, 2024

Hello, I will try to answer your question.

Regarding your first question, currently, only the following parameter is supported in the config.toml file.
image

Regarding your second question, since now iso is not a valid configurable parameter, an error occurred when parsing the config.toml file, which caused it to fall back to using the default empty configuration. In this case, the actual configuration is determined by the runtime parameters.

Now, this parameter has been replaced by output-format="si".

So you can refer to this for your config.toml content.
image

I will submit a PR to update this file.
image

@svm-zhang
Copy link
Author

@wugeer, much appreciate your help. It makes sense. Hopefully, we could specify multiple REGEXs in an array in the TOML file in the future. I will keep using alias for now.

@bootandy
Copy link
Owner

Thank you @wugeer

@svm-zhang
Copy link
Author

@bootandy, could I expect this be implemented as a feature in the future? Thanks

@bootandy
Copy link
Owner

bootandy commented Sep 3, 2024

I never thought people would want to put a regex filter in config, let alone multiple, but yes I think we can add that.

@svm-zhang
Copy link
Author

Thank you. I am learning Rust and if I feel comfortable with it in the near future, I will try to implement it and have a PR, given that this is likely a rare use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants