Make getenv thread-safe
#191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to return a non-owning pointer without memory leaks the function needs to use a static variable. When calling it from multiple threads there is a data race during the assignment (and conversion) to this variable. Fix by making it `thread_local`. Fixes #189
Flamefire
force-pushed
the
get-env-thread
branch
8 times, most recently
from
1af7cff to
96cecd0
Compare
Using `bash` puts `/mingw64/bin` first in the path but the compiler from `/c/mingw64/bin` is used. This leads to errors running the tests: "Exit code 0xc0000139" (DLL issue) which are related to the use of `thread_local`. Using the powershell works in all cases.
Flamefire
force-pushed
the
get-env-thread
branch
2 times, most recently
from
4e7d4b7 to
d96b3cf
Compare
Flamefire
force-pushed
the
get-env-thread
branch
from
d96b3cf to
ce96657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to return a non-owning pointer without memory leaks the function needs to use a static variable.
When calling it from multiple threads there is a data race during the assignment (and conversion) to this variable.
Fix by making it
thread_local.Fixes #189