Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beast CMakeLists is no longer compatible with cmake 3.8 #2956

Closed
anarthal opened this issue Nov 27, 2024 · 3 comments · Fixed by #2957
Closed

Beast CMakeLists is no longer compatible with cmake 3.8 #2956

anarthal opened this issue Nov 27, 2024 · 3 comments · Fixed by #2957

Comments

@anarthal
Copy link

The CMakeLists.txt refactor performed in commit 75e4528 seem to have broken compatibility with CMake 3.8. See this MySQL build: https://drone.cpp.al/boostorg/mysql/955/3/3

The problem seems to be that target_sources(... PRIVATE) is not supported for INTERFACE targets in CMake 3.8.

This problem only happens in develop.

@ashtum
Copy link
Collaborator

ashtum commented Nov 27, 2024

Thanks for reporting this! Did you check if target_sources is the only issue?

@anarthal
Copy link
Author

anarthal commented Nov 27, 2024

It's the only problem reported by the build. It may be covering other issues. If you want to test locally, you can use the ghcr.io/anarthal-containers/build-cmake3_8 Docker image (it's an Ubuntu with cmake 3.8)

@ashtum
Copy link
Collaborator

ashtum commented Nov 27, 2024

Yes, it seems that's the only issue.

@ashtum ashtum linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants