You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey,
First of all thanks for your work on this lib and offering some fixes and fresh air to the Jazzband version.
I have found a small issue in the admin that should be simple to fix, see below.
I have also found the UX of the EventForm a bit complex and misleading. I will come back a bit later to comment / PR on this if you are ok with the idea.
Thanks
Description
When trying to save a model in the admin, the following error shows up: container is not defined
Coming from the following:
if (event.recurrence_rule) {
const foreverRadio = container.querySelector('input[name^="end-recurrence"][value="forever"]');
//....
}
To fix this, I have added the validateDateInputs function like so:
function validateDateInputs() {
const container = calendarEntryForm.container // NEW
}
The text was updated successfully, but these errors were encountered:
Hmm strange, I can't reproduce that. Can you post a screenshot of the event you were trying to create please?
As for the UX it basically wraps datetime's rruleset pretty tightly. I initially found it unintuitive that the start/end dates were of the event itself and the recurrence rule controlled (surprise) recurrence. Intuitively I wanted to create an event that ran from e.g. 1-31 October as the start/end times, but that's not how rruleset works. I've tried to address that with help text. Maybe that's what you're referring to?
Hi @boosh , sorry, busy couple of past days.
I was using django-unfold in the project where I observed these issues, so to be on the safe side I created a fresh project with nothing else that your package and I haven't been able to reproduce this issue either.
Re-installed django-unfold in this test project and the error was back. Not sure what's causing it but that's not a bug with the Django stock UI. I will keep looking into it, and in the meantime update the issue title accordingly.
Cheers.
Stf-F
changed the title
container is not defined
Container is not defined with django-unfold
Oct 22, 2024
Hey,
First of all thanks for your work on this lib and offering some fixes and fresh air to the Jazzband version.
I have found a small issue in the admin that should be simple to fix, see below.
I have also found the UX of the EventForm a bit complex and misleading. I will come back a bit later to comment / PR on this if you are ok with the idea.
Thanks
Description
When trying to save a model in the admin, the following error shows up:
container is not defined
Coming from the following:
To fix this, I have added the
validateDateInputs
function like so:The text was updated successfully, but these errors were encountered: