Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Move the registry plugin to core Bookshelf.
Motivation
This is a useful plugin and is the best way to ensure there are no circular dependencies issues when models are located in different files.
Fixes #1557.
Proposed solution
Functionality is moved to the
bookshelf.js
file. Note that registered models and collections are now stored in thebookshelf.registry.models
andbookshelf.registry.collections
respectively. This means the change is not backwards compatible but it's not expected that users were accessingbookshelf._models
andbookshelf._collections
directly anyway.A lot of the code was modernized.