Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid connections are allowed when inserting include workflows with no input arguments from the toolbox #800

Closed
glopesdev opened this issue Aug 9, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@glopesdev
Copy link
Member

glopesdev commented Aug 9, 2021

Include workflows containing no nested WorkflowInput nodes do not allow input connections from other nodes, i.e. connecting an input to a nested workflow with no declared inputs will be rejected by the editor. This is the expected behavior so the nested node works as a regular operator.

However, the editor does not honor nested WorkflowInput declarations on IncludeWorkflow nodes when inserting include extensions from the toolbox, and will allow the selected node to be connected to the newly inserted node regardless of whether the included workflow accepts inputs or not.

This is especially problematic when chaining multiple included workflows with no inputs, as the editor will try to chain them all into a single subscribe chain, when in fact what you probably want is to add them as independent nodes.

@glopesdev glopesdev added the bug Something isn't working label Aug 9, 2021
@glopesdev glopesdev added this to the 2.6.3 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant