Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting the Show Visualizer context menu selection to None on visualizer window close #1841

Open
ncguilbeault opened this issue Jun 11, 2024 · 2 comments · May be fixed by #1848
Open
Labels
bug Something isn't working
Milestone

Comments

@ncguilbeault
Copy link

When a user closes a visualizer window by clicking the X in the top right corner, the Show Visualizer option in the context menu doesn't change. My initial thought was that the context menu should update to Show Visualizer > None, but then I found that the visualizer settings persist because the Visible flag in the layout file gets set to false, while setting the Visualizer explicitly to None erases these settings entirely.

Related to #1823 and perhaps does not need its own issue, but at least for me I find it confusing to exit out of the visualizer window and still see that the visualizer is selected. Double clicking on the node or changing selection can make it visible again, but maybe a simple fix would just be to always set Visible -> true on selection in context menu.

@glopesdev
Copy link
Member

@ncguilbeault The reason why we do this is so you can close a visualizer and then bring it back with the same visualizer settings. I agree it is confusing that it still shows it is selected, but this is a behavior we want to keep since otherwise you would have to change things like axis ranges, history length, etc. every time you close and reopen a visualizer.

Maybe we need an extra status indicator to show whether it is selected and visible, versus only selected, would that work?

@ncguilbeault
Copy link
Author

@glopesdev The extra status indicator would definitely be helpful. I still think it would still be nice to have the ability to reopen the visualizer directly from the menu options even if the selection doesn't change. I tried to make a PR to fix this

@glopesdev glopesdev added the bug Something isn't working label Aug 2, 2024
@glopesdev glopesdev added this to the 2.9 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants