Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade helper doesn't respect comments from earlier versions #1097

Closed
Peter-Vincent opened this issue Oct 24, 2022 · 1 comment · Fixed by #1132
Closed

Upgrade helper doesn't respect comments from earlier versions #1097

Peter-Vincent opened this issue Oct 24, 2022 · 1 comment · Fixed by #1132
Labels
bug Something isn't working
Milestone

Comments

@Peter-Vincent
Copy link

Peter-Vincent commented Oct 24, 2022

We've upgraded some computers from Bonsai 2.6 to 2.7.

For files that were edited in 2.6, if there are commented bits of code that contain any node that has changed from 2.6 to 2.7, those comments are no longer respected. For example, if there is a workflow that includes a subject in at at some point that was commented out in 2.6, in 2.7 that workflow is no longer commented out after that subject. See attached workflow:

disabled_nodes_simple.zip

Opening the workflow using Bonsai v2.6 several comments are visible. Opening the workflow with Bonsai v2.7 will re-enable originally disabled subject nodes.

It would be ideal if there is a quick program that parses through the old files from 2.6 and prepares them for 2.7.

@glopesdev glopesdev added the bug Something isn't working label Oct 31, 2022
@glopesdev glopesdev added this to the 2.7.1 milestone Oct 31, 2022
@glopesdev
Copy link
Member

glopesdev commented Oct 31, 2022

@Peter-Vincent I was finally able to repro this issue. It affects only a combination of comments and certain updated nodes such as subjects, but it is symptomatic of a subtle yet general issue with the update mechanism.

We will fix it in the patch release.

@glopesdev glopesdev changed the title v2.7 doesn't respect comments from earlier versions Upgrade helper doesn't respect comments from earlier versions Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants