Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Appium to the list of Drivers #29

Closed
lfarnell opened this issue May 31, 2016 · 9 comments
Closed

Adding Appium to the list of Drivers #29

lfarnell opened this issue May 31, 2016 · 9 comments

Comments

@lfarnell
Copy link

I've started using your library for a project of mine and was wondering if you would be interest in a pull request for adding Appium drivers to the list.

@bonigarcia
Copy link
Owner

Sure, PR's are welcome!

Please provide JUnit tests with your code in order to assess the new feature. Thank you!

@bonigarcia
Copy link
Owner

Did you manage to add Appium to the driver list?

@lfarnell
Copy link
Author

@bonigarcia not yet but i'm hopeful to do so in the next little bit

@rosolko
Copy link
Contributor

rosolko commented Nov 13, 2016

@bonigarcia @lfarnell I used appium for some time. Appium works with own server (like selenium server standalone) and we don't need to store and add some variables to PATH. I formed the opinion that we should't implement this type of driver. All of because from site(bitbucket) installs old version of appium server and GUI. And really latest version installs from node. From my point of view, the implementation of this functionality useless.

@bonigarcia
Copy link
Owner

I've reviewed Appium and @rosolko has a point.

@lfarnell Could you explain to us what is your idea for supporting Apium in WebDriverManager?

@lfarnell
Copy link
Author

cc @bonigarcia @rosolko

Your point merely only says it shouldn't be implemented because BitBucket has old version's of Appium. I personally think that by incorporating Appium into the list, user's can have a seamless experience starting the Appium server and mobile tests simultaneously rather then having to start another process and ensuring that it's running before executing tests. That in itself seems very problematic.

For the dependency on node.js for "newer" verisons of Appium, I dont see why you can't say node.js will be a dependency if you want to run Appium. Plenty of tools and libraries require dependencies.

@bonigarcia
Copy link
Owner

As Linus Torvalds said: "Talk is cheap. Show me the code".

@rosolko
Copy link
Contributor

rosolko commented Nov 16, 2016

@lfarnell But on other hand - archive from bitbucket contains installer, not a driver(like chromedriver) that using like a bridge. In this case tool didn't manage webdrivers.

@bonigarcia
Copy link
Owner

This issue seems to be abandoned. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants