test(core): add initial tests #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc3a263 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
approved these changes
Nov 22, 2024
Adds some tests for the core package and fixes a small bug found during writing them. The bug is basically that we never unhide the cursor on `process.exit` conditions, meaning we leave it hidden in the terminal after our prompt has been cancelled.
Mist3rBru
added a commit
to Mist3rBru/clack
that referenced
this pull request
Nov 26, 2024
Mist3rBru
added a commit
to Mist3rBru/clack
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some tests for the core package and fixes a small bug found during writing them.
The bug is basically that we never unhide the cursor on
process.exitconditions, meaning we leave it hidden in the terminal after our prompt has been cancelled.cc @natemoo-re i was trying to get my head around how this codebase works etc so wrote these while i was in there. they're not as nice as some kind of e2e cli test i suppose, but still seem straight forward enough (and better than nothing)