-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hvplot (bokeh backend) using groupby with active legend is flickering in VSCode Notebook #207
Comments
This probably belongs in the main repo. Although it may be specific to notebooks, it looks like a layout issue, rather than anything to do with the extension, which mostly only handles communication with the kernel. That said, it it would be much preferable to have a pure Bokeh MRE. |
I have no idea how to create a MRE in bokeh. I don't know how the process works in holoviews and what happens if the value of the slider changes. And I can't find out where callback function is placed. I tried to build a figure in a VSCode Notebook with with a slider where the data source is updated by a CustomJS callback. This works totally fine. As I mentioned before I did run the same code in JupyterLab and there is no flickering. But I believe it doesn't run that smooth like in VSCode. For me, and this is only guessing, I believe that VSCode, for some reason, doesn't wait until the updated figure is finally finished. But again, I have no idea how to proof my ideas with an example. |
Yeah, this is definitely odd. I'm not a VSCode user so a quick question, does the VSCode browser console have a Profiler like the Chrome Browser profiler? That'd at least let us see what's happening. |
Neat, if you could try going to the Performance tab, hit record, drag the slider until the bug occurs, stop recording and then zoom in on the time interval where the issue occurs and take a screenshot of the resulting flamegraph. I'd do it but can't promise when I'd get around to it. |
Cc @pavithraes IIRC there was a similar issue in a tutorial example at scipy. |
Thanks, I can indeed open it but strangely it seems to show only VSCode internals, can't actually see any calls into Bokeh happening. Will have to poke around myself. |
Ah strange, couldn't see that on my end. |
I hoped the export would include more information. I tried my best. |
No, really appreciate it! Will dig in more later. |
This is a duplicate of holoviz/hvplot#1369. I was asked to open the same issue here.
I am running a
hvplot()
on axarray
in aJupyter Notebook
inVSCode
and the figure is flickering if it has a legend.The changing size of the figure with the legend is unwanted and makes is hard to focus on the shown data. To me it looks like the figure is updated twice, once without the legend and then the total available space is used, and a second time with the legend.
If this is right, there is somewhere in the process a unneeded calculation.
All software version info
Python, HvPlot, Panel, BokehVSCode
Comment
I was trying to reproduce this in a browser in
JupyterLab
andJupyterNotebook
but there was no flickering. I don't know why. I guess the update frequency can be different, which could explain the different visual observations.The text was updated successfully, but these errors were encountered: