Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math.hypot.length should be 2 #1269

Closed
HalidOdat opened this issue May 21, 2021 · 2 comments · Fixed by #1288
Closed

Math.hypot.length should be 2 #1269

HalidOdat opened this issue May 21, 2021 · 2 comments · Fixed by #1288
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics E-Easy Easy good first issue Good for newcomers
Milestone

Comments

@HalidOdat
Copy link
Member

Describe the bug
Math.hypot.length should be 2 not 1

To Reproduce
Steps to reproduce the issue, or JavaScript code that causes this failure.

This JavaScript code reproduces the issue:

var a = Math.hypot.length;
a;

Expected behavior
Running this code, a should be set to 2 and printed, but a is instead set to 1.

spec

@HalidOdat HalidOdat added bug Something isn't working good first issue Good for newcomers E-Easy Easy builtins PRs and Issues related to builtins/intrinsics labels May 21, 2021
@Razican
Copy link
Member

Razican commented May 22, 2021

As a hint to anyone coming to implement this, this is part of the Math builtin implementation :) feel free to ask questions on how this is implemented.

@moadmmh
Copy link
Contributor

moadmmh commented May 28, 2021

I can fix this

@Razican Razican added this to the v0.12.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics E-Easy Easy good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants