From a9f9784ca5cf984ae00cc25ce2ff1258eb06f552 Mon Sep 17 00:00:00 2001 From: Edgar Date: Sun, 3 Mar 2024 16:17:46 +0100 Subject: [PATCH 1/2] :bug: Fixed v8_torque_generated failing to build on Windows The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that --- CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 143fcb03..e449b4f9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -999,6 +999,9 @@ target_include_directories(v8_torque_generated ${PROJECT_SOURCE_DIR}/v8 ) +# The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that +file(WRITE "${PROJECT_BINARY_DIR}/touch_torque_outputs.cmake" "file(TOUCH ${torque-outputs};${torque_outputs})") + add_custom_command( COMMAND torque @@ -1006,7 +1009,7 @@ add_custom_command( -v8-root ${PROJECT_SOURCE_DIR}/v8 ${torque_files} COMMAND - ${CMAKE_COMMAND} -E touch ${torque-outputs} ${torque_outputs} + ${CMAKE_COMMAND} -P ${PROJECT_BINARY_DIR}/touch_torque_outputs.cmake DEPENDS torque ${torque_dirs} From 82f99614184133e11b121bceef4d29b9e519d481 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 4 Mar 2024 10:03:29 +0100 Subject: [PATCH 2/2] long lines --- CMakeLists.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e449b4f9..4467e77e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -999,8 +999,11 @@ target_include_directories(v8_torque_generated ${PROJECT_SOURCE_DIR}/v8 ) -# The torque-outputs and torque_outputs variables can have too many characters on Windows to be executed on the command line, so we have to write it to a temporary file and execute that -file(WRITE "${PROJECT_BINARY_DIR}/touch_torque_outputs.cmake" "file(TOUCH ${torque-outputs};${torque_outputs})") +# The torque-outputs and torque_outputs variables can have too many characters +# on Windows to be executed on the command line, so we have to write it to a +# temporary file and execute that +file(WRITE "${PROJECT_BINARY_DIR}/touch_torque_outputs.cmake" + "file(TOUCH ${torque-outputs};${torque_outputs})") add_custom_command( COMMAND